Closed saecki closed 3 years ago
I have no idea why this is failing, any help would be great.
I removed the tap animations, fixed the comments and also found a theme bug in the popup-menu of the toolbar.
Thank you! Now that you mention the toolbar popup-menu, I see the icons seem to be the wrong color (black on grey) in dark mode:
Everything else looks perfect to me. I can't thank you enough for going the extra mile and addressing all the nitpicks.
So it turns out that menu icons are only recolored if they are xml vector graphics. After replacing the repeat, repeat_one and reorder icon the theme matches. Maybe all png icons should be replaced by vector graphics anyway...
So it turns out that menu icons are only recolored if they are xml vector graphics. After replacing the repeat, repeat_one and reorder icon the theme matches. Maybe all png icons should be replaced by vector graphics anyway...
Android inconsistencies never ceases to amaze, thanks for updating these three. I am reluctant to invest time (yours too) into upgrading all the icons to vector format, as I am focusing on prototyping the Flutter version mentioned above.
For now, I am happy to merge this and I am about to deploy it to the Beta release channel🍾
Would you mind somehow sharing or publishing the development repository? It would be really interesting to take a look.
Sure thing! It's in this same repository, over on the flutter branch.
This adds a new preference to select either the system, light or dark theme requested by #26. I tried to keep the style of the dark theme as close to the light one as possible so there is definitely room for improvement.