search

agex-inc / support.requests

Shared repository to collect bug reports and new feature requests
0 stars 0 forks source link

Slide amount/direction validation #246

Open altemeier opened 4 years ago

altemeier commented 4 years ago

Report

Timestamp

5/7/2020 12:08:11

Is this bug also in the DEMO and/or PRODUCTION environments?

Yes, the bug also occurs in DEMO and/or PRODUCTION

Email Address

salt@agex.io

How severe is this issue?

LOW: would be nice to fix when we can

What was the email (or phone number) for the account you were using?

salt@agex.io

What device were you using?

Multiple

What part of the system needs work?

Herd

What actually happened?

Users can enter a slide amount without a slide direction. Without a slide direction, the slide amount has no effect.

Consider

  1. requiring slide direction when slide amount is present
  2. warning the user that the slide amount will have no effect
  3. automatically setting slide direction to "both" if slide direction is empty when slide amount is entered

Were you using a "native" or "web" app?

Native (downloaded from a store)

In what screen/page did you find the bug?

Sale wizard > Contract Details

What environment were you working in?

TEST

Is this a bug or a new feature request?

Bug (something unexpected is happening)

joshpavlovich commented 4 years ago

Let's check with Blake about the order of entry for slide and slide direction, since they are dependent fields. I think we currently have a rule if the slide is empty or zero the the direction is set to "Both".

altemeier commented 4 years ago

@blakewagex please let us know your thoughts.

altemeier commented 4 years ago

I just spoke with @blakewagex. @joshpavlovich @eharo2 please confirm whether the acceptance criteria below work for you.

altemeier commented 4 years ago

Acceptance Criteria

  1. Slide direction is only enabled/active if slide amount is set to a non-zero value. Otherwise, slide direction is disabled and visually communicates to the user that it is inactive (e.g., by using opacity).
  2. Slide direction has the following options:
    1. Up
    2. Down
    3. Both
  3. The default value for slide direction is "Both"