search

agfline / LibAAF

Library for Advanced Authoring Format (AAF) file reading.
GNU General Public License v2.0
25 stars 5 forks source link

Unrelated functions in libAAF #11

Closed x42 closed 9 months ago

x42 commented 9 months ago

libAAF is a library to handle AAF files it should not concern itself with anything else.

Please consider removing unrelated functions from the library that are not directly related to AAF. e.g. aafi_enable_windows_VT100_output.

agfline commented 9 months ago

I understand and I agree. However, AAF being such a complex file structure, the only way I found for debugging was to put colors and UTF-8 symbols to print a tree of objects and classes to stdout. No problem for that on linux, but windows requires that VT100 output trigger... Maybe this function could be left as a helper function for development only ?

umlaeute commented 9 months ago

i agree with @x42 that this shouldn't be part of the public API.

afaict, this function is used by the tools AAFExtract and AAFInfo, so why not put it into a private header (tools/AAFTools_utils.h) that is included by these two tools and be done with it?

agfline commented 9 months ago

Yes, but at some point it will be problematic if users request support with those uncolored debug traces. But maybe that's another problem.