search

agfline / LibAAF

Library for Advanced Authoring Format (AAF) file reading.
GNU General Public License v2.0
25 stars 5 forks source link

Reliance on non-standard location parameters #12

Closed dvzrv closed 9 months ago

dvzrv commented 9 months ago

Hi! :wave: I am currently trying to package this library for Arch Linux as it is now an implied requirement for ardour.

I noticed that in https://github.com/agfline/LibAAF/blob/3e4c2cd4ae3c6ebb6598f78cba30278a86f4232f/CMakeLists.txt#L62-L64 you are hardcoding non-standard location parameters.

This is very bad for downstream packaging as one can not override these locations without patching the CMakeLists.txt.

Please instead rely on GNUInstallDirs, which is a builtin facility of cmake. Reinventing the wheel here will unfortunately be very painful for anyone else otherwise.

All that downstreams should have to pass in to cmake when it comes to defining install location is -D CMAKE_INSTALL_PREFIX=/usr to modify the prefix used for the target location.

I can try and have a look whether I can provide a patch for this.

agfline commented 9 months ago

Hi, Never used cmake before, so any help is appreciated ;) I will fix that soon, thanks for pointing that out and for the explanations.