search

agfline / LibAAF

Library for Advanced Authoring Format (AAF) file reading.
GNU General Public License v2.0
25 stars 5 forks source link

tools: Include "common.h" for aafi_enable_windows_VT100_output() #19

Closed umlaeute closed 9 months ago

umlaeute commented 9 months ago

my PR #18 moved aafi_enable_windows_VT100_output() into a tools/common.c (cleaning up the API).

unfortunately, I forgot to actually include the corresponding common.h file in the tools, which lead to nasty warnings like:

.../LibAAF/tools/AAFExtract.c:102:9: warning: implicit declaration of function ‘aafi_enable_windows_VT100_output’ [-Wimplicit-function-declaration]

this PR should fix this. sorry for the mess

Related: https://github.com/agfline/LibAAF/issues/11

umlaeute commented 9 months ago

sidenote: if you (like me) like a linear git history (at least for single-commit PRs), you could select the Rebase and merge option instead of the default Create a merge commit merging strategy.

Or perform the merge locally (rather than via the webinterface)

agfline commented 9 months ago

Thanks for the tip. I'm actually learning git with that AAF/Ardour project...

agfline commented 9 months ago

Already fixed in dd138ef thanks ;)