search

agg23 / fpga-gameandwatch

Game and Watch for Analogue Pocket and MiSTer
MIT License
57 stars 2 forks source link

Rom generator fails when layout contains `collection` elements #3

Open goldenegg opened 1 year ago

goldenegg commented 1 year ago

Version (or build number)

0.1.0

Platform (Pocket or MiSTer)

N/A

Steps to reproduce

Run ROM generator with the syntax from the documentation against a MAME .250 merged romset.

Expected Behavior

No response

Actual Behavior

Running the ROM generator on Windows and Mac both result in the same error.

C:\Users\goldenegg\windows>fpga-gnw-romgenerator.exe --mame-path e:\mametemp --output-path e:\output supported

Processing device gnw_ball

thread 'main' panicked at 'called Result::unwrap() on an Err value: Custom { field: "unknown variant collection, expected one of bounds, element, screen" }', src\layout.rs:139:80

Additional Context

Confirmed that the required ROMs and artwork are present. The required files can be extracted manually.

agg23 commented 1 year ago

Interesting. Would you happen to be using an alternative artwork?

Could you please attach the default.lay file from your artwork zip?

goldenegg commented 1 year ago

Correction. It's a MAME 0.251 romset being used.

goldenegg commented 1 year ago

default.lay.zip

It's a standard artwork files from the 0.250 extras set.

goldenegg commented 1 year ago

I got an artwork set from another source and ROM generator worked. Not sure why the files from what's supposed to be the official set aren't working. I'll raise it with their team, but I'll leave it to you whether or not you want to close this ticket.

agg23 commented 1 year ago

This is a really weird layout. It's completely different than all other's I've seen, and it even uses completely different "View" names (the different user-selectable ways of presenting the layers of the image) than the rest of the artwork, so my tool would be unable to accurately choose the correct view.

I should support this, but it's not going to be trivial work. It's probably not going to happen soon.