search

agg23 / openfpga-NES

NES for the Analogue Pocket
GNU General Public License v3.0
192 stars 8 forks source link

Added Y + B mapping to Nes via toggle switch #15

Closed terminator2k2 closed 1 year ago

terminator2k2 commented 1 year ago

updated, hope all is good

dhorlick commented 1 year ago

I appreciate the change, but I think it could do a better job of anticipating future button-remapping options. For example, suppose later we wanted to implement another option to treat the Y button as a redundant B button and the X button as a redundant A button. What then would happen if this option were already toggled on?

It's tough to iterate on these things after they're out in the wild…

agg23 commented 1 year ago

This is not the permanent feature, and will be removed as soon as Analogue releases button remapping. Therefore future proofing is not required (and can't be done; the configured setting will be dropped when the feature is removed/added by Analogue).