search

agg23 / openfpga-NES

NES for the Analogue Pocket
GNU General Public License v3.0
192 stars 8 forks source link

Added basic support for Analogizer #41

Closed RndMnkIII closed 6 months ago

RndMnkIII commented 6 months ago

Added support for the Analogizer: analog video modes: RGBS, RGsB, YPbPr and SNAC. Issue: In SMB3 in menu and map screens YPbPr works Ok, but when Mario/Luigui enters to level screen screen goes black. Returning to map or title screen and image recovers. this could be due to something related to a change in video mode during game phases.

agg23 commented 6 months ago

Thanks for the PR. We need to figure out how to cut down on the settings changes so we can ship Analogizer support with the main build.

Naively I wonder if people aren't going to change things often, so we could have a central config file where you can set up Analogizer stuff. There's also just choosing intelligent defaults, like the polling rates, which I imagine you can determine based on the controller type.

RndMnkIII commented 6 months ago

Hello, you're right, I think that the modifications made to the NES core to support the Analogizer should be in a separate repository, because they can affect the way a user who only wants the Pocket or Pocket+Dock experience can use the core.

RndMnkIII commented 6 months ago

I close this pull request and all changes for Analogizer support will be added to this repository https://github.com/RndMnkIII/openfpga-NES-Analogizer

agg23 commented 6 months ago

I think we should keep the PR open, because the end goal is to upstream all such changes. Having a separate core really isn't ideal.