search

agg23 / openfpga-SNES

SNES for the Analogue Pocket
GNU General Public License v3.0
382 stars 15 forks source link

Add Feature - BSX Loading #89

Open terminator2k2 opened 11 months ago

agg23 commented 11 months ago

I thank you for splitting up the commits, but I would really like the GSU commit to be a part of a separate PR.

The problem with you closing a PR like that and reopening, is now all of the comments and history have been lost, so I have to re-review everything. For future reference, you could have force pushed to the branch, overwriting your previous commits, and Github would have kept history of what happened.

In your closing comment, you stated that MiSTer detects BSX using it's .bs extension. You can accomplish that with GETEXT Rx, Ry.

terminator2k2 commented 11 months ago

Very Sorry about that , thats the reason i hate making/ammending PR's , i find github hard to navigate and not sure where everything is haha. I did try sending both commits as seperate pull requests , but it seemed to have merged them again.

https://github.com/MiSTer-devel/Main_MiSTer/blob/222d61776f3cc534f1e48ec1a6e31a3bc1588752/user_io.cpp#L2502

ill have a read up on what you wrote.

im back in the land of discovery so looking at it all again lol

agg23 commented 9 months ago

@terminator2k2 What is the status on this PR? Did you get everything working?

terminator2k2 commented 9 months ago

@terminator2k2 What is the status on this PR? Did you get everything working?

yes , should be good to go, i also made a patcher here : https://github.com/terminator2k2/BSX-Rom-Patcher for bsx roms as some games were time limited and were only playable on certain days/weeks of release. some info here : https://wiki.superfamicom.org/bs-x-satellaview-header