search

agg23 / openfpga-pokemonmini

GNU General Public License v2.0
35 stars 1 forks source link

Frame blending fails at Pichu Bros Mini game selection menu #4

Open wickjames086 opened 1 year ago

wickjames086 commented 1 year ago

Version (or build number)

0.2.0

Steps to reproduce

No response

Expected Behavior

The flickering checkerboard pattern to resolve into a solid grey color when frame blending is on.

Actual Behavior

While playing Pichu Bros Mini (both the original and fan translation) the game selection menu behaves as if frame blending is off even when it's on.

Additional Context

No response

agg23 commented 1 year ago

I can reproduce this. It seems the frame blending timer is too small, but getting that right is pretty hard.

This issue should be created upstream at https://github.com/MiSTer-devel/PokemonMini_MiSTer; I didn't write the core and probably won't fix this issue across both repos.

Grieverheart commented 1 year ago

It's been nearly a year since I touched the core, and I haven't programmed any other cores in the mean time, so I'm quite rusty. From a quick testing on MiSTer, it seems that the problem has nothing to do with the blending as a tear line is visible without blending on. One possibility is that I'm swapping framebuffers while rendering the frame, which could cause this. I'll have to see if I can get the core compiled again and see if I can fix it. @agg23 if you have any fix in the mean time, let me know.

agg23 commented 1 year ago

I didn't notice the tearing, but that's a good catch. I'm probably not going to look at this very soon, but if you have something in particular you want me to investigate, I might.

Grieverheart commented 1 year ago

Fixed on MiSTer.