search

aggregateknowledge / java-hll

Java library for the HyperLogLog algorithm
http://research.neustar.biz/2013/12/24/open-source-release-java-hll/
Apache License 2.0
312 stars 71 forks source link

int overflow during serialization of a FULL type HLL when log2m and regwidth are both large #17

Open hossman opened 9 years ago

hossman commented 9 years ago

BigEndianAscendingWordSerializer and BigEndianAscendingWordDeserializer both suffer from int overflow bugs: multiplying large ints and then assigning to long instead of casting those ints to longs before multiplying them.

I don't have a pull request handy (since this project no longer seems actively maintained, we've forked & imported directly into the Apache Solr code base) but I wanted to file this issue to make existing users aware of the bug -- you can see the details involved in fixing/testing in this issue/commit in the Lucene/Solr code base...

https://svn.apache.org/viewvc?view=revision&revision=1697969 https://issues.apache.org/jira/browse/SOLR-7954

ragstorooks commented 8 years ago

I've run into the same issue described here and have submitted a new PR. It would be great if you can get it merged so that others facing the same issue can just pull down a newer version rather than fork and maintain their own versions.

Many thanks