agherzan / meta-raspberrypi

Yocto/OE BSP layer for the Raspberry Pi boards
https://www.yoctoproject.org/
MIT License
520 stars 407 forks source link

rpi-cmdline: do_compile: Use pure Python syntax to get `CMDLINE` #1080

Closed lluiscampos closed 2 years ago

lluiscampos commented 2 years ago

Otherwise the shell snippet fails with bad syntax when CMDLINE contains special characters like ${...} (useful to insert a U-Boot variable in cmdline.txt).

- What I did

Modify do_compile so that special characters ${...} are accepted for CMDLINE.

- How I did it

Getting CMDLINE variable through Python with d.getVar()

lluiscampos commented 2 years ago

@agherzan Thanks for your review and approval. What is the process to port patches to stable branches? I would like to bring this one to kirkstone.

agherzan commented 2 years ago

@lluiscampos As soon as it lands in master, just create another MR cherry-picking it for kirkstone. It'd be the fastest way.