search

agherzan / meta-raspberrypi

Yocto/OE BSP layer for the Raspberry Pi boards
https://www.yoctoproject.org/
MIT License
539 stars 415 forks source link

libcamera: rename bbappend to match any version #1103

Closed sung-gon-kim closed 2 years ago

sung-gon-kim commented 2 years ago

libcamera has been renamed in meta-openembedded in: https://github.com/openembedded/meta-openembedded/commit/1032bce77885f20afb40fff4ed430167c75db59b

This patch is to rename the bbappend to match the recently changed recipe name in the above commit.

tewarid commented 2 years ago

Should we rename bbappend to libcamera_%.bbappend to match any upstream package version?

sung-gon-kim commented 2 years ago

Should we rename bbappend to libcamera_%.bbappend to match any upstream package version?

I agree. It seems more appropriate to change it as you said. I will update the PR. Thanks.

sung-gon-kim commented 2 years ago

@agherzan Oh, sorry. I will squash the commit.

shr-project commented 2 years ago

LGTM

shr-project commented 2 years ago

@agherzan Please create langdale branch before this PR is merged, this will be the first change for mickledore (incompatible with meta-oe/langdale).

agherzan commented 2 years ago

@agherzan Please create langdale branch before this PR is merged, this will be the first change for mickledore (incompatible with meta-oe/langdale).

Why would this be incompatible?

shr-project commented 2 years ago

Why would this be incompatible?

@agherzan Because of the filename.

libcamera_%.bbappend won't work with libcamera.bb (before rename from https://github.com/openembedded/meta-openembedded/commit/1032bce77885f20afb40fff4ed430167c75db59b)

agherzan commented 2 years ago

@shr-project all done.