search

agherzan / meta-raspberrypi

Yocto/OE BSP layer for the Raspberry Pi boards
https://www.yoctoproject.org/
MIT License
528 stars 407 forks source link

Add support for Raspberry Pi Camera Module v3 #1158

Closed Jessseee closed 1 year ago

Jessseee commented 1 year ago

I would like to see support for the Raspberry Pi Camera Module v3 which uses the imx708 sensor. Therefore, I added the required device tree overlay and config. I am not able to test this right now but it would be great if an admin could verify this patch.

Jessseee commented 1 year ago

@agherzan any updates on this?

agherzan commented 1 year ago

Up for merge if you could also squash docs: Fixed text wrap consistency and added full stop. into the previous commit. There is no need for incremental changes here.

Jessseee commented 1 year ago

The doc commits have been squashed, should I make any other changes to this PR?

agherzan commented 1 year ago

@Jessseee You have a mismatch between the commit author and the SoB line. Check the CI pipeline for DCO.

Jessseee commented 1 year ago

@agherzan My bad, the authorship of the commits should be corrected.

quaresmajose commented 1 year ago

These break old kernels like latest 5.10 on the layer.

| NOTE: make -j 16 CC=aarch64-lmp-linux-gcc   -fuse-ld=bfd -fmacro-prefix-map=/srv/oe/build/tmp-lmp/work-shared/raspberrypi4-64/kernel-source=/usr/src/debug/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0  -fdebug-prefix-map=/srv/oe/build/tmp-lmp/work-shared/raspberrypi4-64/kernel-source=/usr/src/debug/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0  -fmacro-prefix-map=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/linux-raspberrypi4_64-standard-build=/usr/src/debug/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0  -fdebug-prefix-map=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/linux-raspberrypi4_64-standard-build=/usr/src/debug/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0  -fdebug-prefix-map=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot=  -fmacro-prefix-map=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot=  -fdebug-prefix-map=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot-native=  -fdebug-prefix-map=/srv/oe/build/tmp-lmp/work-shared/raspberrypi4-64/kernel-source=/usr/src/kernel -fdebug-prefix-map=/srv/oe/build/tmp-lmp/work-shared/raspberrypi4-64/kernel-build-artifacts=/usr/src/kernel  --sysroot=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot LD=aarch64-lmp-linux-ld.bfd    --sysroot=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot OBJCOPY=aarch64-lmp-linux-objcopy  HOSTCC=gcc  HOSTCFLAGS=-isystem/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot-native/usr/include -O2 -pipe HOSTLDFLAGS=-L/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot-native/usr/lib                         -L/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot-native/lib                         -Wl,--enable-new-dtags                         -Wl,-rpath-link,/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot-native/usr/lib                         -Wl,-rpath-link,/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot-native/lib                         -Wl,-rpath,/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot-native/usr/lib                         -Wl,-rpath,/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot-native/lib                         -Wl,-O1 -Wl,--allow-shlib-undefined -Wl,--dynamic-linker=/srv/oe/build/tmp-lmp/sysroots-uninative/x86_64-linux/lib/ld-linux-x86-64.so.2 HOSTCPP=gcc  -E HOSTCXX=g++  HOSTCXXFLAGS=-isystem/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot-native/usr/include -O2 -pipe PAHOLE=false overlays/imx708.dtbo CC=aarch64-lmp-linux-gcc   -fuse-ld=bfd -fmacro-prefix-map=/srv/oe/build/tmp-lmp/work-shared/raspberrypi4-64/kernel-source=/usr/src/debug/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0  -fdebug-prefix-map=/srv/oe/build/tmp-lmp/work-shared/raspberrypi4-64/kernel-source=/usr/src/debug/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0  -fmacro-prefix-map=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/linux-raspberrypi4_64-standard-build=/usr/src/debug/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0  -fdebug-prefix-map=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/linux-raspberrypi4_64-standard-build=/usr/src/debug/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0  -fdebug-prefix-map=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot=  -fmacro-prefix-map=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot=  -fdebug-prefix-map=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot-native=  -fdebug-prefix-map=/srv/oe/build/tmp-lmp/work-shared/raspberrypi4-64/kernel-source=/usr/src/kernel -fdebug-prefix-map=/srv/oe/build/tmp-lmp/work-shared/raspberrypi4-64/kernel-build-artifacts=/usr/src/kernel  --sysroot=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot   LD=aarch64-lmp-linux-ld.bfd    --sysroot=/srv/oe/build/tmp-lmp/work/raspberrypi4_64-lmp-linux/linux-lmp-rpi/5.10.110+gitAUTOINC+902d575bc1_8e1110a580-r0/recipe-sysroot OBJCOPY=aarch64-lmp-linux-objcopy
| make[2]: *** No rule to make target 'arch/arm64/boot/dts/overlays/imx708.dtbo'.  Stop.
| make[1]: *** [/srv/oe/build/tmp-lmp/work-shared/raspberrypi4-64/kernel-source/Makefile:1358: overlays/imx708.dtbo] Error 2
| make: *** [/srv/oe/build/tmp-lmp/work-shared/raspberrypi4-64/kernel-source/Makefile:185: __sub-make] Error 2
| ERROR: oe_runmake failed
| WARNING: exit code 1 from a shell command.
quaresmajose commented 1 year ago

The overlays/imx708.dtbo is not supported and backport the dtbo is not accepted so one possible solutions is doping the kernel 5.10 version on the master branch https://github.com/agherzan/meta-raspberrypi/pull/1171.

agherzan commented 1 year ago

For master, I would probably just drop 5.10. Upstream already defaulted it to 6.1 so I reckon that is reasonable. @Jessseee could you follow up with that?