agherzan / meta-raspberrypi

Yocto/OE BSP layer for the Raspberry Pi boards
https://www.yoctoproject.org/
MIT License
525 stars 407 forks source link

omxplayer: fix an error caused by new srcrev fetcher API #1217

Closed sangmo-kang closed 1 year ago

sangmo-kang commented 1 year ago

Fail to parse omxplayer_git.bb after using new srcrev fetcher API

Error message:

ERROR: ExpansionError during parsing /tmp/meta-raspberrypi/recipes-multimedia/omxplayer/omxplayer_git.bb Traceback (most recent call last): File "Var <fetcher_hashes_dummyfunc[vardepvalue]>", line 1, in File "/tmp/poky/bitbake/lib/bb/fetch2/init.py", line 834, in get_hashvalue(d=<bb.data_smart.DataSmart object at 0x7fdac34c1130>, method_name='sortable_revision'): def get_hashvalue(d, method_name='sortable_revision'):

pkgv, revs = _get_srcrev(d, method_name=method_name) return " ".join(revs) File "/tmp/poky/bitbake/lib/bb/fetch2/init.py", line 804, in _get_srcrev(d=<bb.data_smart.DataSmart object at 0x7fdac34c1130>, method_name='sortable_revision'): if not format: raise FetchError("The SRCREV_FORMAT variable must be set when multiple SCMs are used.\n"\ "The SCMs are:\n%s" % '\n'.join(scms)) bb.data_smart.ExpansionError: Failure expanding variable fetcher_hashes_dummyfunc[vardepvalue], expression was ${@bb.fetch.get_hashvalue(d)} which triggered exception FetchError: Fetcher failure: The SRCREV_FORMAT variable must be set when multiple SCMs are used. The SCMs are: git://github.com/popcornmix/omxplayer.git;protocol=https;branch=master git://github.com/FFmpeg/FFmpeg;branch=release/4.0;protocol=https;depth=1;name=ffmpeg;destsuffix=git/ffmpeg The variable dependency chain for the failure is: fetcher_hashes_dummyfunc[vardepvalue]

ERROR: Parsing halted due to errors, see error messages above

- What I did fix an error caused by new srcrev fetcher API

- How I did it Add SRCREV_FORMAT to omxplayer_git.bb

agherzan commented 1 year ago

This required some more fixed. I have included yours in https://github.com/agherzan/meta-raspberrypi/pull/1218. Thanks once again!

sangmo-kang commented 1 year ago

Thanks for merging my changes.