search

agherzan / meta-raspberrypi

Yocto/OE BSP layer for the Raspberry Pi boards
https://www.yoctoproject.org/
MIT License
505 stars 396 forks source link

rpi-base: Added missing HiFiBerry #1284

Closed kluszon closed 1 month ago

kluszon commented 4 months ago

…Pro, DAC+ DSP, DAC+ HD, Digi Pro.

- What I did

Added missing support for HiFiBerry AMP100, AMP3, AMP4 Pro, DAC+ ADC Pro, DAC+ DSP, DAC+ HD, Digi Pro.

- How I did it

Add right lines to rpi-base.inc. Changes were tested and works fine with the branch.

Connected also with issue #1168

agherzan commented 4 months ago

Is this a backport from main? If not, why is this kirkstone-specific?

kluszon commented 4 months ago

Is this a backport from main? If not, why is this kirkstone-specific?

It's not a backport, because on main branch you don't have it. I'm working on kirkstone branch and it's a reason. It could be applied to any branch with kernel 5.10 or newer. I didn't test it with older kernels, but some dtbo files can be not available there.

agherzan commented 4 months ago

In that case, I would like for this to be pushed against main first to avoid feature divergence on maintenance branches.

kluszon commented 4 months ago

@agherzan Ok then pull request prepared #1287

kluszon commented 4 months ago

@agherzan Can you do a cherry-pick from 92a9b7a01245507a347c59997a3e5960b0f75ae9 to the Kirkstone branch and close it?

agherzan commented 3 months ago

@kluszon Could you refresh this MR by recreating the branch with the cherry-pick of the commit you've prepared for master? This will kick the gears here and run the CI for kirkstone too.l

kluszon commented 3 months ago

@kluszon Could you refresh this MR by recreating the branch with the cherry-pick of the commit you've prepared for master? This will kick the gears here and run the CI for kirkstone too.l

Done

agherzan commented 2 months ago

@kluszon the builds fail with:

| make[1]: *** No rule to make target 'arch/arm/boot/dts/overlays/hifiberry-amp4pro.dtbo'. Stop.

kluszon commented 2 months ago

@kluszon the builds fail with:

| make[1]: *** No rule to make target 'arch/arm/boot/dts/overlays/hifiberry-amp4pro.dtbo'. Stop.

Your kernel doesn't have the file. I compiled it locally without any problem. What should I do with it?

agherzan commented 2 months ago

I wish I had a kernel :) Joke aside, you're probably building a different version, and not the default kirkstone one. You can see here https://github.com/agherzan/meta-raspberrypi/blob/master/.github/workflows/docker-images/yocto-builder/entrypoint-build.sh how the CI builds the kernel.

kluszon commented 1 month ago

I wish I had a kernel :) Joke aside, you're probably building a different version, and not the default kirkstone one. You can see here https://github.com/agherzan/meta-raspberrypi/blob/master/.github/workflows/docker-images/yocto-builder/entrypoint-build.sh how the CI builds the kernel.

The only I can do is remove the problematic amp4pro.