agherzan / yubikey-full-disk-encryption

Use YubiKey to unlock a LUKS partition
Apache License 2.0
821 stars 51 forks source link

Add support for yubikey-manager #103

Open NgoHuy opened 12 months ago

NgoHuy commented 12 months ago

Because yubikey-personalization is not under active development, I add support for yubikey-manager. It works fine on my machine for format, enroll and open. I did not test NFC because I do not have NFC machine. For hooks, I added ykman and od, it should work. README should be modified if this commit is approved.

Vincent43 commented 12 months ago

As discussed in the issue ykman isn't drop-in replacement for yubikey-personalization so this is incompatible change

NgoHuy commented 12 months ago

My patch is compatible with previous version. You can use it with your old challenge. You should read my patch again.

NgoHuy commented 11 months ago

I added new commit to address those issue. Please test it

NgoHuy commented 11 months ago

There is problem on hooks, I will look at tomorrow. Python is dificult to add library.

Vincent43 commented 11 months ago

Yes yubikey-manager has a lot of python deps. Adding them to initramfs would be a challenge.

NgoHuy commented 11 months ago

We have few options:

NgoHuy commented 11 months ago

I tested with pyinstaller successfully, but the initramfs's zise is around 50Mb if we find all python's libraries, we need some .so files. I have an idea, unpack pyinstaller's output and add those files which in plain text.

NgoHuy commented 11 months ago

I added new commit, please check it, it works with hooks on my machine.

agherzan commented 11 months ago

Can you please squash the commits that are iterative and update the git log to help review?

NgoHuy commented 11 months ago

I squashed commit, please review it.