search

agherzan / yubikey-full-disk-encryption

Use YubiKey to unlock a LUKS partition
Apache License 2.0
808 stars 50 forks source link

[Feature Suggestion] Plymouth Support #19

Closed VGrol closed 5 years ago

VGrol commented 6 years ago

Plymouth is a tool used to display the initial bootstages better. You can read more about it here.

It however, requires the Encrypt hook to be replaced with Plymouth-encrypt. Since YKFDE replaces the encrypt module as well, I was wondering if you could make a plymouth compatible version.

Vincent43 commented 6 years ago

That should be possible. Debian version supports plymouth already: https://github.com/cornelinux/yubikey-luks/blob/master/key-script#L14 . I'm not using plymouth on Arch right now. If you want, you may try to tweak it yourself and give us feedback.

agherzan commented 6 years ago

It's an interesting feature request. I'm not a plymouth user either but it shouldn't be a hard task.

Vincent43 commented 6 years ago

I think it can be implemented within same hook, just check if plymouth is running and then read password from plymouth instead of console.

doniom commented 5 years ago

Hello, is it possbile to support plymouth-encrypt? Please

benruijl commented 5 years ago

Here is a patch of the ykfde hook with support for Plymouth: ykfde.txt

For some reason I cannot get on-screen text to work. The plymouth-encrypt hook does have text below the password prompt and I have no idea why it doesn't work in the ykfde hook. Any suggestions?

Vincent43 commented 5 years ago

@benruijl thx, if you open PR with your patch included it will be easier to investigate 😄 .