search

agherzan / yubikey-full-disk-encryption

Use YubiKey to unlock a LUKS partition
Apache License 2.0
795 stars 50 forks source link

Added Plymouth support #49

Closed benruijl closed 5 years ago

benruijl commented 5 years ago

Fixes #19

benruijl commented 5 years ago

Somehow the text is not displaying under the password prompt. I have no idea why.

edward-p commented 5 years ago

@benruijl

You just forgot the install script at src/install/ykfde

Try this patch: (It works, at least for me.)

--- src/install/ykfde       2019-04-29 01:06:04.343333558 +0800
+++ src/install/ykfde       2019-04-29 00:54:04.629999960 +0800
@@ -43,6 +43,13 @@
   add_file "/usr/lib/udev/rules.d/95-dm-notify.rules"
   add_file "/usr/lib/initcpio/udev/11-dm-initramfs.rules" "/usr/lib/udev/rules.d/11-dm-initramfs.rules"

+  # plymouth on-screen text needed
+  add_binary "/usr/lib/plymouth/label.so"
+  add_binary "/usr/lib/plymouth/text.so"
+  add_file "/usr/share/fonts/TTF/DejaVuSans.ttf"
+  add_file "/etc/fonts/fonts.conf"
+  add_file "/etc/fonts/conf.d/60-latin.conf"
+  
   # cryptsetup calls pthread_create(), which dlopen()s libgcc_s.so.1
   add_binary "/usr/lib/libgcc_s.so.1"
edward-p commented 5 years ago

@benruijl

You just forgot the install script at src/install/ykfde

Try this patch: (It works, at least for me.)

--- src/install/ykfde       2019-04-29 01:06:04.343333558 +0800
+++ src/install/ykfde       2019-04-29 00:54:04.629999960 +0800
@@ -43,6 +43,13 @@
   add_file "/usr/lib/udev/rules.d/95-dm-notify.rules"
   add_file "/usr/lib/initcpio/udev/11-dm-initramfs.rules" "/usr/lib/udev/rules.d/11-dm-initramfs.rules"

+  # plymouth on-screen text needed
+  add_binary "/usr/lib/plymouth/label.so"
+  add_binary "/usr/lib/plymouth/text.so"
+  add_file "/usr/share/fonts/TTF/DejaVuSans.ttf"
+  add_file "/etc/fonts/fonts.conf"
+  add_file "/etc/fonts/conf.d/60-latin.conf"
+  
   # cryptsetup calls pthread_create(), which dlopen()s libgcc_s.so.1
   add_binary "/usr/lib/libgcc_s.so.1"

However, this will fail the mkinitcpio, if plymouth is not installed.

We need add an if statement, or create a new hook like:

benruijl commented 5 years ago

I think an if-statement if nicer, to prevent having two almost identical hook files.

edward-p commented 5 years ago

I think an if-statement if nicer, to prevent having two almost identical hook files.

Agree. Since we can always use ESC to check the outputs.

Vincent43 commented 5 years ago

@benruijl I merged your PR alongside some improvements in https://github.com/agherzan/yubikey-full-disk-encryption/commit/aacf45583bffd7034adc665b3ec90084051ed03c. Thank you for contribution.