aghontpi / ad-silence

Mute Ad/promotions from Accuradio, Spotify, Soundcloud, TIDAL & Pandora Android. Minimal, extensible & lightweight under 150kb.
GNU General Public License v3.0
192 stars 11 forks source link

Extend app functionality to Deezer #10

Open Cwpute opened 2 years ago

Cwpute commented 2 years ago

Yes, this is coming from someone with almost no knowledge on how this might work. But! I do know that ads in Deezer are also signaled by a separate notification which could be detected by the app and subsequently silenced.

I use Deezer and i believe it's among the topmost used streaming apps! many other users might find this helpful πŸ‘€

(also happy holidays πŸŽ„)

aghontpi commented 2 years ago

Thanks for the suggestion, will add it for sure.

Happy Holidays!

aghontpi commented 2 years ago

block deezer ads

aghontpi commented 2 years ago

deezer is not available in my country and is region locked, (even after using vpn, the app wont let me signin). I have to find a way to overcome this.

is it supported in your country? or are you using a method(vpn,etc...) to make it work?

Cwpute commented 2 years ago

Yes it is supported in my country (France). I didn't know it would be blocked in others !

aghontpi commented 2 years ago

added support for Deezer in #11 , closing this issue.

@Cwpute thanks for request !

Cwpute commented 2 years ago

Fantastic ! thank you !!

aghontpi commented 2 years ago

πŸ˜„ yw.

I have to test it for a few days before publishing it, so If you want to test it immediately head over here.

You can also provide feedback on whether it works or not, (im limited to an emulator 😭 , it would be of great help)

Cwpute commented 2 years ago

Tested it just now and it doesn't work :/ the app is running in the notifications and Deezer is checked on in the settings. Not sure why it doesn't work.

aghontpi commented 2 years ago

I just tested it now, works as expected πŸ€”

aghontpi commented 2 years ago

can you take a screenshot of the Deezer notification when an ad plays next time and post it here.

Cwpute commented 2 years ago

Screenshot_20211231-203630

aghontpi commented 2 years ago

thanks for the screenshot, from the notifications..

I can tell the above has happened for sure, because if a configured app (i.e) "Deezer/Spotify.. in preference" posts a new notification, the title of ad-silence would be "Ad-silence . now" but it shows "Ad-silence . 16h", which indicates adsilence last detected something 16 hours ago and did not detect Deezer or anything since. (can you test it again with the build 10 from #11)

or the app might be killed (but notification is not removed...which has a less probability, need logcat to confirm this)

Can you specify the device model/specs? (optional, if you are into dev.. and have a pc, can you take a logcat?. I can send you the instructions)

edit/update: do mention if it works for other apps (spotify/accuradio/Tidal)

aghontpi commented 2 years ago

If I have extra time available, I can decomple/reverse engineer the Deezer app to patch the location restriction..then I can test it on my device, fingers crossed~

Cwpute commented 2 years ago

My phone is a Huawei Y5 2018 DRA-L21 running on Android 8.10. I don't think the app was killed as it was listed in the opened-apps window as Deezer was playing. I'll try to use it with Spotify ! Last time i tried to use Logcat it didn't work… but if someone helps me through i might be able to use it.

Cwpute commented 2 years ago

It works perfectly with Spotify on the same device… so the issue must be specific to the Deezer app.

aghontpi commented 2 years ago

there should be no hiccups for android 8 andad-silence would not show up in recents πŸ€” (its configured not to be seen in recents screen/running apps screen). but Spotify works.. so it clears the possibility of system killing the app.

What problems did you face ? I can help you set it up.

aghontpi commented 2 years ago

Can you verify Deezer's package name is deezer.android.app, it will be under app Info.

aghontpi commented 2 years ago

An update~

I have decided it would be better to merge the Deezer branch #11 into master instead of keeping it stale, So others can test this and report.

Put Deezer under an experimental section and ship with main build. (something like below or a better UI)

experimental-example-ui

famewolf commented 2 years ago

I have not seen deezer in the list. If it's hidden unless the app is installed I can install it and try to get a logcat along with some screenshots.