search

aghstrategies / com.aghstrategies.airmail

Unified CiviCRM bounce event handler for SMTP services
Other
8 stars 13 forks source link

use Civi::settings not Civi::cache for settings #21

Closed MegaphoneJon closed 1 year ago

MegaphoneJon commented 2 years ago

Currently, Airmail uses Civi::cache() for settings, mailing IDs and mailing jobs. On a multi-site, the last two are the same across domains, but settings are per-site. This leads to errors when loading/saving settings on child sites.

Moreover, Civi::settings() is already cached, so I was able to cut down the getSettings() and saveSettings() code considerably, and Airmail now works on multi-site installations.

I also took out some debug code from #14.

PS - The docs for SES setup are out of date again with SESv2, though good enough to muddle through. If I get around to updating them, I'll also make a note for multi-site installs that all sites must have the same bounce "address" as the first site.

agh1 commented 1 year ago

This looks good on the face of it - going to merge so we can do some testing alongside #22 and other changes