aghstrategies / com.aghstrategies.civimonitor

CiviCRM Monitoring for Nagios
Other
4 stars 4 forks source link

small params fix to avoid warnings #8

Closed michau closed 8 years ago

michau commented 8 years ago

Without this fix, CiviCRM cron runs were giving me warnings from CRM/Core/BAO/Setting.php:

Illegal string offset 'type' Setting.php:613                   [warning]
Illegal string offset 'group_name' Setting.php:516             [warning]

After applying this change, warnings went away. Tested on CiviCRM 4.6.14 on Drupal.

michau commented 8 years ago

Added yet another small change to this pull request - returning 'OK' instead of empty message when system check runs without any warnings/criticals.

agh1 commented 8 years ago

I think 1b011e23d4a4afdbfdc4c9b51affc8b3ae982651 is what's really needed for the warnings rather than this. Meanwhile, I cherry-picked your "OK" commit as 7a6f32a66b28c8a18cdea3afaecdbfc6232ef134