search

agibralter / ts-resque-delta

ThinkingSphinx + Resque delta indexing.
MIT License
69 stars 36 forks source link

why make the Gemfile entry require a `:require`? #7

Closed agibralter closed 13 years ago

agibralter commented 13 years ago

Is there any good reason why this has been a convention in TS-related gems:

 gem 'ts-resque-delta', '1.0.0', :require => 'thinking_sphinx/deltas/resque_delta'

as opposed to:

 gem 'ts-resque-delta', '1.0.0'
agibralter commented 13 years ago

@freelancing-god -- any thoughts?

pat commented 13 years ago

ts-resque-delta (and equivalents) are abbreviations, I feel, hence why I used the full path. Now, I'm not so fussed - for example, with Thinking Sphinx I added lib/thinking-sphinx.rb, so you don't need to specify a :require option. I see no issue with doing something similar here.

agibralter commented 13 years ago

Yeah, I'm going to change it and update the README. I think it's more elegant to just have people specify the gem and get the most desired behavior. Plus with Rails 3 now, we can automatically load Rake tasks.

pat commented 13 years ago

Yeah, about time with the Rake task stuff - Merb had that from early on.

On 08/09/2011, at 11:42 AM, Aaron Gibralter wrote:

Yeah, I'm going to change it and update the README. I think it's more elegant to just have people specify the gem and get the most desired behavior. Plus with Rails 3 now, we can automatically load Rake tasks.

Reply to this email directly or view it on GitHub: https://github.com/agibralter/ts-resque-delta/issues/7#issuecomment-2035799