Refactor CLI handling - Githubissues

agicommies / communex

alternative commune cli/sdk

MIT No Attribution

24 stars 15 forks source link

Refactor CLI handling #20

Open steinerkelvin opened 6 months ago

steinerkelvin commented 6 months ago

[ ] use make_custom_context in all CLI command functions, like in save
[ ] all output and input goes through the CustomCtx interface
[ ] all informative and error outputs go to stderr, such that that relevant output can be parsed (specially on JSON output mode)
[ ] disable colors and input on non-interactive shells/scripts/etc
[ ] JSON output option for all commands

Bakobiibizo commented 4 months ago

I started working on error handling which is related to this but not exactly what the post requests. Let me know if I should make a separate issue. Currently have

custom exception classes
added a logger sink to a file Planning to
add a default error to incorrect cli inputs that just displays the help menu you're currently on. Saves you from having to the type --help everytime to see the menu since the messaging is verbose in this application and its inconvenient to scroll up.

steinerkelvin commented 4 months ago

@Bakobiibizo

I think the library should not be writing log files by default, but I appreciate it if this is a feature gated by an environment variable.

Open at least a PR draft, so I can view your changes already plz