agicommies / subspace-network

MIT No Attribution

3 stars 1 forks source link

feat: add validator blacklist #202

Closed devwckd closed 3 weeks ago

devwckd commented 1 month ago

Pull Request Checklist

Before submitting this PR, please make sure:

[ ] You have run cargo clippy and addressed any warnings
[ ] You have added appropriate tests (if applicable)
[ ] You have updated the documentation (if applicable)
[ ] You have reviewed your own code
[ ] You have updated changelog (if applicable)

Description

Please provide a brief description of the changes in this PR.

Related Issues

Please link any related issues here

devwckd commented 1 month ago

@Supremesource or @saiintbrisson pls run benchmarks for me and fix the pallet calls if possible, I cant run them, thanks :D

devwckd commented 4 weeks ago

Fix the ensures please. Also you need to check if the person calling both extrinsic is acutally a subnet owner of that netuid, you don't do this now

@Supremesource doesn't this work?

        let params = Self::subnet_params(netuid);
        ensure!(params.founder == key, Error::<T>::NotFounder);

Supremesource commented 3 weeks ago

Fix the ensures please. Also you need to check if the person calling both extrinsic is acutally a subnet owner of that netuid, you don't do this now

@Supremesource doesn't this work?
        let params = Self::subnet_params(netuid);
        ensure!(params.founder == key, Error::<T>::NotFounder);

Oh, yeah, it does, I must have missed that