search

agilbert1412 / StardewArchipelago

Archipelago Implementation for Stardew Valley
11 stars 12 forks source link

Create mappers for crafting IDs #74

Closed Witchybun closed 2 months ago

Witchybun commented 2 months ago

Crafting had a similar disconnect, but it was for IDs, not internal names. So I do a workaround here.

I checked some cooking locations. Cooking maps aren't necessary, just works it seems.

Tested by crafting several things from bug reports, plus checking the "Craft " list from the locations list, and making a few cooking recipes from several mods to be sure cooking was fine.

To note, the SVE recipes strangely just use their actual names. So they work out of the box.

Witchybun commented 2 months ago

I don't disagree with any of the specific code, but I think a more generic approach IF it works, would be preferable. So I pushed some changes to 6.x.x which will maybe cover all those cases. If they do, we can close this PR. If they don't, they'll probably still help, so we can probably delete a bunch of entries and merge the PR for the remaining few ones

Agreed.

I've pulled your changes, and reverted mine up to Trash Bin. This one still had a problem due to the discrepency between its actual name and internal name.

Should look into some more methods to fix this more dynamically.