search

agile-leaf / 50mm

Create minimal HTML5 image galleries from S3 buckets.
MIT License
57 stars 12 forks source link

every photo detail page makes S3 HEAD request #11

Closed arahayrabedian closed 6 years ago

arahayrabedian commented 7 years ago

My growing understanding of 50mm is still limited, but i think this blob for ImageExists can be significantly improved to not require a (blocking (and paid albeit in very small amounts)) request to S3 to confirm existence of a photo.

I'm not sure why it's even required since the album indices should be up to date enough via caching for an inconsistent situation not to last very long.

arahayrabedian commented 6 years ago

I just realised this should be a trivial fix once #14 makes it in

theonejb commented 6 years ago

If this is solved by your latest pull request, please mark as closed.

arahayrabedian commented 6 years ago

it's solved by the one i just opened ( #15 , not #14 ), one needed the other

arahayrabedian commented 6 years ago

haha you're going to murder me, but that's the only other work i've done :)

theonejb commented 6 years ago

@arahayrabedian Already merged! I can't go around murdering collaborators to this repo, I'd be left alone to work on it then!

Thanks for your help!