I didn't remove any of the pipes to logs. I want a second opinion before I do that.
Changes so far:
Removed logs, current, and setcurrent arguments
Removed profile validation logic, now errors straight from docker. If there's a docker error, lists profiles.
Added list-services and list-profiles arguments
On docker error for mh tail, will call listServices
Improvements to be made:
[x] (Possibly) Remove all pipes to $INSTALL_PATH/logs
[ ] Current behavior for upProfile and tailServiceLogs is if docker compose returns with a status of 1, they print their respective list of options. This means that if a container fails to start and errors out from mh up, listProfiles gets called. I'm not sure of a way to list profiles on an invalid entry without re-adding profile validation logic, unless we just let the user manually use list-profiles.
I didn't remove any of the pipes to logs. I want a second opinion before I do that.
Changes so far:
logs
,current
, andsetcurrent
argumentslist-services
andlist-profiles
argumentsmh tail
, will calllistServices
Improvements to be made:
upProfile
andtailServiceLogs
is ifdocker compose
returns with a status of1
, they print their respective list of options. This means that if a container fails to start and errors out frommh up
,listProfiles
gets called. I'm not sure of a way to list profiles on an invalid entry without re-adding profile validation logic, unless we just let the user manually uselist-profiles
.Thoughts/feedback?