search

agilebits / onepassword-app-extension

1Password Extension for iOS Apps
2.58k stars 312 forks source link

Use passwordGenerationOptions to check manually entered pasword #291

Closed lionel-alves closed 8 years ago

lionel-alves commented 8 years ago

passwordGenerationOptions is really useful but it's too bad that if the user just enter a password manually 1Password doesn't check any of these options. Would be great just to rename passwordGenerationOptions to passwordOptions and check these if the user tap a password manually (on top of using them for the password generation). Any chance this could happen?

Thanks!

radazzouz commented 8 years ago

Hi @lionel-alves,

Thanks for taking the time to write in :+1:

passwordGenerationOptions is really useful but it's too bad that if the user just enter a password manually 1Password doesn't check any of these options.

The password generation options are taken into consideration if the user manually types the password.

For example, if you build and run ACME and sign up, you will notice that the ! and the / cannot be typed in the 1Password extension item detail view. See the list of forbidden characters that it uses.

Would be great just to rename passwordGenerationOptions to passwordOptions and check these if the user tap a password manually (on top of using them for the password generation). Any chance this could happen?

The options that the developer pass, are primarily intended to be used for the Password Generator. Renaming passwordGenerationOptions to passwordOptions may be misleading if not a confusing for some. We want to be as explicit as we can in this case.

For now I am closing this issue, but please do let me know if you have any other questions.

All the Best!