search

agilebits / onepassword-app-extension

1Password Extension for iOS Apps
2.58k stars 312 forks source link

new/ios10 branch doesn't include Carthage support #332

Closed lvandal closed 8 years ago

lvandal commented 8 years ago

Seems like the Xcode project is missing from this branch.

radazzouz commented 8 years ago

Hi @lvandal,

Thank you for taking a look at the new iOS 10 branch and for taking the time to writer in! 👍

Just like on master, this branch has the main Xcode workspace (1Password Extension Demos.xcworkspace) located in onepassword-app-extension/Demos/ and an Xcode project (.xcodeproj file) located in each demo app's directory.

Which Xcode project file are you missing? Is it OnePasswordExtension.xcodeproj? If so, then please note that this Xcode project is only available in the add-framework-support branch.

I look forward to your reply!

Cheers!

radazzouz commented 8 years ago

Linking this issue to #329.

lvandal commented 8 years ago

I can simply copy the Xcode project file and Info.plist in order for Carthage to work with the new/ios10 branch but I was wondering if at some point you'll either add the missing files or create a new branch for add-framework-support?

radazzouz commented 8 years ago

Thanks so much for the quick response, Luc!

We haven't started to work on iOS 10 + Carthage compatibility yet. We will very soon. We'll most likely branch from add-framework-support and rebase the changes from new/ios10 to the new branch.

Please stay tuned! I'll comment on this issue when the new branch is ready!

Cheers!

radazzouz commented 8 years ago

I just published the new/carthage+ios10 branch for Carthage compatibility with Xcode 8 and Swift 3.

I am closing this issue as duplicate, so that we centralize discussions in #329.

@lvandal, please let me know if things work fine for you from the new branch.