search

agilebits / onepassword-app-extension

1Password Extension for iOS Apps
2.58k stars 311 forks source link

Converted to swift 3 syntax #352

Closed krider2010 closed 7 years ago

krider2010 commented 7 years ago

Also updated some of the code to be more “swifty”.

gks commented 7 years ago

Hi @krider2010

Thanks for taking the time to do this! You might be interested in Issue #329 and the corresponding branch.

There is an explanation in that Issue as to why we have not yet moved to Swift 3 and why we're holding off on making that transition to master until a later date. If you have any changes you'd like to see to new/ios10, please feel free to PR them against it.

For now though I think this PR will get closed. I hope you'll agree.

krider2010 commented 7 years ago

So I'm clear, I can make this PR for swift 3 against the new/iOS10 branch? I really think having example code for swift 3 is important. Everyone I know, even commercially, is now biting the bullet and dealing with swift 3 given that Apple will flip the switch within the Xcode 8 lifecycle.

gks commented 7 years ago

@krider2010 You can definitely PR against it if you think it fits the topic. I'm not sure I can promise it'll be merged, but I'm happy to take a look at it against that branch instead.

krider2010 commented 7 years ago

Fair enough!

gks commented 7 years ago

Thanks! Closing this PR :)