search

agilebits / onepassword-app-extension

1Password Extension for iOS Apps
2.58k stars 311 forks source link

Swift 3 compatibility #353

Closed krider2010 closed 7 years ago

krider2010 commented 7 years ago

Also updated some of the code to be more “swifty”. I've made use of Any rather than AnyObject and removed a lot of casts that are no longer necessary.

Resolved merge issues with new/ios10.

For additional reference (since the .gitignore doesn't check them in), set the OS_ACTIVITY_MODE to be disable in Environment Variables which can be found by editing the ACME scheme, and selecting Run/Debug.

gks commented 7 years ago

@krider2010 Very sorry about the delay in getting this looked at. I have a colleague of mine who is far better versed in Swift 3 taking a look at this soon (probably tomorrow). We'll see what kinds of things he shakes up and go from there. This does appear to be fairly minimal changes that are probably going to work fine though so I don't see any particular reason why it can't be merged once we've fully reviewed it. Thanks for your patience!

rudyrichter commented 7 years ago

over all it looks good, and since this is just the demo project i think its probably ok to merge this since Xcode 8 has arrived and these changes don't impact our ability to still build the main extension with our 7.3.1 release toolchain.

gks commented 7 years ago

Well, this appears to be dead so I'm closing for now but will happily accept another pull request that fixes the necessary comments.

Otherwise, when Swift 3 or 4 becomes standard for Apple we'll update things ourselves.