search

agilebits / onepassword-app-extension

1Password Extension for iOS Apps
2.58k stars 311 forks source link

Issue with 1Password Extension in TestFlight Builds #359

Closed pres closed 7 years ago

pres commented 7 years ago

I'm seeing a weird issue that I have no explanation for.

I have the 1password extension in my app since quite a while now. I recently updated to 1.8.4 and to cocoapods 1.1.0 (from 0.39).

The issue is, that the 1password buttons in the app are not showing when the app is installed using TestFlight.

Except the App Store version everything else used the same commit. Same OS (10.1) and same device.

Any idea what the issue could be? Or is it perfectly normal that the extension does not work using TestFlight builds?

gks commented 7 years ago

You could possibly add some logging to see what result you get back for the [[OnePasswordExtension sharedExtension] isAppExtensionAvailable] call. It returns a bool. My guess is that for some reason you're getting back an incorrect value here (not sure why in this case) or possibly how you're handling the resulting action is behaving differently with TestFlight builds than those run from Xcode.

I assume you're using the same stable version of 1Password for this test? Or are you also using a TestFlight build?

pres commented 7 years ago

1Password App is the latest version from the App Store.

pres commented 7 years ago

Ok … I fixed.

It seems there was an issue the button image. I used [UIImage imageNamed:@"onepassword-button.png" inBundle:onepasswordExtensionResourcesBundle compatibleWithTraitCollection:nil];

After your comment I added logging to sign up and registration. And also changed signup to simply use [UIImage imageNamed:@"onepassword-button"]; + copied the button in our Apps xcassets.

After creating a new TestFlight Build both signup and registration are working again.

gks commented 7 years ago

Great to hear you got it figured out :)

Thank you again for integrating with 1Password!