search

agilebits / onepassword-app-extension

1Password Extension for iOS Apps
2.58k stars 311 forks source link

UIWebView vs WKWebView code does not work with Catalyst #409

Closed dvshelley closed 4 years ago

dvshelley commented 4 years ago

With Catalyst, UIWebView is not a defined class. So code like the following and others isn't going to compile.

NSAssert([webView isKindOfClass:[UIWebView class]] || [webView isKindOfClass:[WKWebView class]], @"webView must be an instance of WKWebView or UIWebView.");

Sidetalker commented 4 years ago

Apple is also now preventing new submissions that include UIWebView - I'm forking this repo and removing all references to UIWebView, I'll submit a PR here once I'm done.

Sidetalker commented 4 years ago

@dvshelley you should be able to use https://github.com/Sidetalker/onepassword-app-extension/tree/add-framework-support. I'm hesitant to open a PR because I don't have any iOS <= 8 devices to test with + my changes likely break support for that iOS.

Sidetalker commented 4 years ago

Opened PR to address this https://github.com/agilebits/onepassword-app-extension/pull/411

rudyrichter commented 4 years ago

resolved by #417