search

agilebits / onepassword-app-extension

1Password Extension for iOS Apps
2.58k stars 311 forks source link

UIPopupPresentationController crash in iPad on iOS 12.4 #412

Closed Wallethub closed 2 years ago

Wallethub commented 4 years ago

Hello,

We started seeing an increasing number of crashes in our app on the iPad device with iOS 12.4 that looks like this:

Screen Shot 2019-09-10 at 5 20 50 PM

After investigating our code we narrow it down to the possibility that the onepassword extension may be causing this when invoking findLoginForURLString at line:

[viewController presentViewController:activityViewController animated:YES completion:nil];

Is there a way to resolve this? Or at least determine if this really is the cause or not. Through our tests, we could not replicate the crash.

Koze commented 4 years ago

@Wallethub I think that you need to set sender argument when call findLoginForURLString on iPad. https://github.com/agilebits/onepassword-app-extension/blob/ba96cf1203f6ea749b7c3f4e921b15d577536253/OnePasswordExtension.m#L83

sender is used in below for configuring popover. https://github.com/agilebits/onepassword-app-extension/blob/ba96cf1203f6ea749b7c3f4e921b15d577536253/OnePasswordExtension.m#L478-L484

rudyrichter commented 2 years ago

In light of the retirement of this extension, I'm closing out any remaining issues and branches.