UIWebView deprecation - Githubissues

agilebits / onepassword-app-extension

1Password Extension for iOS Apps

2.58k stars 311 forks source link

UIWebView deprecation #417

Closed rudyrichter closed 4 years ago

rudyrichter commented 4 years ago

This commit does several things:

Moves all projects forward to Xcode 11 format
Updates build settings and localization targets
Converts swift projects to Swift 5
Moves the bar forward from iOS 7 to iOS 9
Removes all support for UIWebView
Removes the deprecated call - (void)fillLoginIntoWebView:(nonnull id)webView forViewController:(nonnull UIViewController *)viewController sender:(nullable id)sender completion:(nonnull OnePasswordSuccessCompletionBlock)completion;
Updates Readme.md urls, removes mention of a newsletter

Resolves: #414, #409, #369

Ashoat commented 4 years ago

Thanks for making this PR @rudyrichter! I can't seem to find the new v1.8.6 of this CocoaPod online. Wondering if the release will happen soon or if there is an alternative way to pull the CocoaPod directly from GitHub.

mccarron commented 4 years ago

Thanks for making this PR @rudyrichter! I can't seem to find the new v1.8.6 of this CocoaPod online. Wondering if the release will happen soon or if there is an alternative way to pull the CocoaPod directly from GitHub.

Doesn't look like @rudyrichter and team have pushed the lastest version to Cocoapods Trunk yet, but until then you can grab it this way:

pod '1PasswordExtension', :git => 'https://github.com/AgileBits/onepassword-app-extension.git', :branch => 'master'

It works great, so thanks all around!