search

agilebits / onepassword-app-extension

1Password Extension for iOS Apps
2.58k stars 312 forks source link

Add framework support #422

Closed rudyrichter closed 3 years ago

rudyrichter commented 4 years ago

This PR adds support for building a framework version of the extension support.

rudyrichter commented 4 years ago

@Sidetalker and @felixrosenvik we'll probably move this forward from 1.8.3, but i think most everything here looks ok to me. I would like to see if there is anyone that isn't interested in using this as a framework and that it still works as a source include for those developers.

mccarron commented 4 years ago

Since I use this as a Cocoapod would love to see it be updated to a Framework as adding support for Swift Package Manager should be easy then.

Can this warning fix #423 also get included in the release?

ksullivan1-chwy commented 4 years ago

@rudyrichter any update here? Still hoping to see this merged in. This shouldn't impact anyone who wants to continue using source code. I'm happy to contribute SPM support once this is in!

dvshelley commented 4 years ago

Are you going to merge this PR or make a framework/1.8.6 tag?

rudyrichter commented 3 years ago

In light of the retirement of this extension, I'm closing out any remaining issues and branches.