Queue names always include dev whatever the stage

[owenbendavies]

When running as a different stage, e.g.

serverless deploy --stage staging

with the following config

service: platform-backgroundjobs

plugins:
  - '@agiledigital/serverless-sns-sqs-lambda'

resources:
  Resources:
    Topic:
      Type: AWS::SNS::Topic
      Properties:
        ContentBasedDeduplication: true
        FifoTopic: true
        TopicName: !Join ['', [!Ref AWS::StackName, '.fifo']]

functions:
  example:
    handler: src/handlers/example.handler
    events:
      - snsSqs:
          batchSize: 1
          fifo: true
          maxRetryCount: 1
          name: message
          rawMessageDelivery: true
          topicArn: !Ref Topic

The lambda functions are named correctly, e.g. platform-backgroundjobs-staging-example however the queues are named with dev, e.g. platform-backgroundjobs-dev-ExamplemessageQueue.fifo and platform-backgroundjobs-dev-ExamplemessageDeadLetterQueue.fifo

Thank you for your plugin as it cleans up the code a lot rather than writing the cloudformation resources manually.

[NoxHarmonium]

Hi there, thanks for the report!

That might be related to the recent change to add fifo queues. I'll try and have a look at it this weekend.

[robinMcA]

@NoxHarmonium I think that that it could also be related to how severless creates the stage variable. https://github.com/agiledigital/serverless-sns-sqs-lambda/blob/master/lib/serverless-sns-sqs-lambda.ts#L293 the default naming pull in ${stage} from the serverless config. https://github.com/agiledigital/serverless-sns-sqs-lambda/blob/master/lib/serverless-sns-sqs-lambda.ts#L202 Need to see what --stage staging sets.

[robinMcA]

@NoxHarmonium is only this line will look at adding test for it later.

[NoxHarmonium]

@owenbendavies a workaround for now while we get the fix through would be adding your stage name to the provider section of your serverless config,

For example:

provider:
  stage: ${opt:stage, 'dev'}

You may need to tweak that a bit if you use something like environment variables for your stage.

[NoxHarmonium]

Since this will technically be a breaking change, maybe this is our opportunity to bump up the version to v1

[owenbendavies]

@NoxHarmonium adding stage to provider worked as a temporary solution, thank you.

[NoxHarmonium]

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: