Add option to disable dead letter queue

[NoxHarmonium]

Hi @m9rc1n, thanks for the contribution!

Out of curiosity, what was the reason you needed to disable the DLQ in the project you were using this plugin? Was it just for simplicity or did you want to bring your own DLQ or something like that?

It looks like the tests are failing because we are no longer hitting our test coverage target after adding the new branches. Would it be possible to write a test that confirms that the DLQ and associated IAM policies are not created when that attribute is set to false?

There should be some examples in https://github.com/agiledigital/serverless-sns-sqs-lambda/blob/master/lib/serverless-sns-sqs-lambda.test.ts#L566 It should be as simple as adding a snapshot of the relevant area of the template.

[m9rc1n]

Hi @NoxHarmonium,

Thanks for your reply. We are using your plugin at my current workplace and we decided to resign from DLQ to reduce costs mostly (+ simplicity).

I will add tests and will get back to you shortly! Marcin

[m9rc1n]

Hi,

Test added 👍🏻

[m9rc1n]

@NoxHarmonium could you check my MR? Tests were added but still not running. I have 1 more MR to publish

[NoxHarmonium]

Sorry for the delay @m9rc1n. Tests are passing and the change LGTM. I'll merge it now.

[NoxHarmonium]

Oh I forgot to check that the commits were in the right format for semantic release (e.g. https://www.conventionalcommits.org/en/v1.0.0/#summary)

I'll force a release this time, but in the future commits should follow that standard

[NoxHarmonium]

:tada: This PR is included in version 2.1.0 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket:

[m9rc1n]

Sure @NoxHarmonium, thanks for fixing it!