agilescientific / modelr-app

Modelr front end
Apache License 2.0
0 stars 1 forks source link

wiggle fill weirdness on 1D model #157

Closed EvanBianco closed 8 years ago

EvanBianco commented 9 years ago

Consider a reflection at the very bottom of the depth track. In this case the wiggle trace fill goes out of whack. It might have to do with the curve not being restored to the zero crossing at the top or base of the trace.

It seems to get this behavour if the last sample of the trace is a negative number, but works as expected when the last sample is greater than zero.

This is something that should become part of the testing.

image

ben-bougher commented 9 years ago

This is super tricky, we do the wiggle fill using a simple css style, so when it breaks like this it is out of our hands.

We might need to redo the wiggle fills by drawing a rect, then using the line as a clip path? @kwinkunks any SVG or css voodoo for dealing with this?

ben-bougher commented 8 years ago

Rhe g3 wiggle plot has fixed this weirdness.