Provide a fix for issue #126

agilescientific / striplog

Lithology and stratigraphic logs for wells or outcrop.

https://code.agilescientific.com/striplog

Apache License 2.0

204 stars 69 forks source link

Provide a fix for issue #126 #130

Closed Zabamund closed 3 years ago

Zabamund commented 3 years ago

In the init method, all TypeError instances were ignored as they were assumed to be catching instances of None. They were also catching instances of tuples though and here I suggest being explicit about catching the instances of None and adding other valid objects in the same way as for ValueError instances.

coveralls commented 3 years ago

Coverage increased (+0.1%) to 75.423% when pulling 57388b470c3a3062608f97d22b569d2de877af02 on Zabamund:issue126 into b2d6cc3c8145073f62a7e5060973877fdbe56f63 on agile-geoscience:develop.

kwinkunks commented 3 years ago

Awesome! Please can you add a couple of tests for this?

Zabamund commented 3 years ago

Yep in the process of writing tests right now :-)

kwinkunks commented 3 years ago

Okay, please add the commit to this PR, I think that should be possible

Zabamund commented 3 years ago

I'm not sure how to fix this as before my commit, coverage was at 75.254% and it's now higher at 75.423%. The two tests I added cover the code I added, namely checking for None and for tuples in the initialisation of a Component. Any suggestions?

Zabamund commented 3 years ago

thank you for merging despite that failed coverage Matt :+1: