Closed DanielMiller-agile6 closed 1 year ago
I think we were using the light blue for text before, so we should maybe change these to dark blue?
Name | Link |
---|---|
Latest commit | b8df7394a5a5f741c092cdfa0118e6687652bbc9 |
Latest deploy log | https://app.netlify.com/sites/agile6/deploys/645978719867620008044e06 |
Deploy Preview | https://deploy-preview-52--agile6.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Are you doing the logo swap in this PR as well?
i was planning on it , although a little busier this week than i hoped with PI planning. if you'd like to add that, or post a separate PR for it I could just focus on the colors here :) up to you 👍
EDIT: i just got the svg from josh, so i'll add this in this PR for now, and we can reconsider the logo asset later on if we think it's useful 👍
ok, i tried out a fix by using the new "red" as the color for page subtitles, other than the Home page (which uses a dark BG with white and light-blue title and subtitle). Let me know if this is an ok solution, or else we could try different colors for page subtitles
actually, just realized our link text was using the old light blue too... i really should have merged my storybook PR before this lol
not sure i want to use the new red like i did for subtitles, and the new dark blue could work but doesn't contrast with surrounding text to well 🤔 . i think i'll reverse the old link underline effect to make these links more distinct and play with colors a bit before posting a new preview.
K, here's a screenshot of the new links. Let me know if this works :)
WIP
Posting this early for testing. This just replaces the color palette tailwind variables for colors, but we may want to tweak a few things. I found a few issues, so I'll post comments below, but this PR should allow for more people testing with the preview site.
Also, just discovered that the previous A6 logo was a hardcoded svg 🤦 . I think I want to update the CMS for this, so we can replace the logo outside of the code in the future, but will take a little longer. If it takes too long, I might work out a half measure for the time being, and replace with CMS content in future.