Open agileurbanite opened 2 years ago
If the user has visited multisafe before, when disconnecting account we should just persist that in local storage so that when the user re-authenticates the safe can be added back in. It is strange though to get visibility on a safe that you have no permissions over.
If the user has visited multisafe before, when disconnecting account we should just persist that in local storage so that when the user re-authenticates the safe can be added back in.
@agileurbanite That's a great idea.
There is one issue. At this moment Multisafe is supporting only one account at a time, so it's storing (in local storage) state for one account only.
There might be a situation:
Of course, we can leave it this way, but I think it would be better to handle it and make it work properly. We can solve it by:
An additional advantage would be that by introducing this functionality we will be able to introduce functionality to support multiple accounts much easier if we would decide to do that - it will be basically ready.
Additional thing is that if we would like to keep the state in local storage, I think we should do two additional things:
Disconnect and remove all safes data
button - it will allow the user to completely remove all data related to this account that is stored in the local storage - easy way to remove all account/safes state.Disconnect
should be changed to Logout
- I think if Disconnecting
will not be removing safes, Logout
will be a bit better name.It is strange though to get visibility on a safe that you have no permissions over.
@agileurbanite So if we would like to support showing a safe data to user that isn't a member, we can handle it much better. IMO we should separate it from loading safe flow, and the existing safes list. So the user will not be loading
safe that he's not a member, but he will be able to see safe data. For example on the landing page we can have a button Show safe data
, and the user can enter safeId (without a name) and see all (or partial) data.
With this, it would be also possible to share the link to the safe, without the need to load the safe. For example, if someone would like to share the safe data with someone who is not a member.
Also, we need to handle situations, when a user was a member of the safe, so he has this safe on the safes list, but he was removed from the safe members.
Loading existing multisafe is not obvious UX that you need to enter the full account name of a multisafe to use said multisafe....
Almost a BUG imo.