Bug - Debounce RPC calls for validating Account Ids - Githubissues

agileurbanite / ui.multisafe

5 stars 8 forks source link

Bug - Debounce RPC calls for validating Account Ids #144

Closed roshaans closed 2 years ago

roshaans commented 2 years ago

In the current state of the app, we are sending an RPC call for every single input into the Member ID and Multisafe ID fields.

This type of validation is done in many flows in the app such as while transferring funds #104(soon to be implemented) and editing members of a multisafe.

It could possibly overload our RPC node causing bad UX for everyone using the application or our other apps that rely on the same RPC endpoint.

Solution

Debounce the requests similar to the implementation of Near-wallet here.

the # requests in the Network Tab

too_many_calls

Patrick1904 commented 2 years ago

@roshaans let's go ahead and only validate account ID's on blur and form submit, vs while typing. This will reduce RPC calls ~10x. Instant account ID validation makes more sense when trying to create a new account, but in the multisafe case, we can assume that the user knows what account ID they're entering, so validating once the user blurs the form input, and submits the form, should be enough.