search

agileurbanite / ui.multisafe

5 stars 8 forks source link

Account ID pattern improvements #71

Closed mikedotexe closed 2 years ago

mikedotexe commented 3 years ago

I believe regex patterns need to updated to include valid subaccounts.

https://github.com/multi-safe/ui.multisafe/blob/a9d9bc2fc1fd1c6c5c62ada1c01f7ea6484a214a/src/utils/validation/CreateMultisafePage.js#L24

and potentially:

https://github.com/multi-safe/ui.multisafe/blob/a9d9bc2fc1fd1c6c5c62ada1c01f7ea6484a214a/src/utils/validation/SendFundsModal.js#L14

Note the error here that should be valid: Screen Shot 2021-10-13 at 3 52 44 PM

I also noticed it is failing on legitimate account names:

I'm looking in the Wallet code, and this seems to be the more loose regex they're using. At some point in the future, people will be able to have the account mike on mainnet without it having to be mike.near.

https://github.com/near/near-wallet/blob/072515eb8c2eedb75a89ddbdc94d7c86ef3c276a/packages/frontend/src/components/send/components/InputAccountId.js#L131

Note this valid account: Screen Shot 2021-10-13 at 4 16 09 PM

mikedotexe commented 3 years ago

Potentially related to #56

eclipseeer commented 2 years ago

Fixed