agileurbanite / ui.multisafe

5 stars 8 forks source link

Add ability to update members and number of confirmations #95

Closed marcinbodnar closed 2 years ago

marcinbodnar commented 2 years ago

Changes: 1. Added functionality to change Safe members. At first, I was planning to add changing members functionality to the Members page:

2. Added functionality to change the number of confirmations. This is implemented as a separate form because it's not possible to change the members and number of confirmations in one request.

3. Added Settings section to the main menu. So far the options were scattered in the UI, so I decided to create 3 new forms:

4. Reorganized the main menu. Dashboard and History names didn't say much, so I change them to the Requests section and two sub-items: Pending and Completed.

marcinbodnar commented 2 years ago

Thanks @judith-Near , I will handle it in a separate PR.

agileurbanite commented 2 years ago

talking about regarding validation, the issue is also on the "edit members".

steps to reproduce:

  1. click add member
  2. write a new member id
  3. things are fine until you click add member a second time -> then the error message shows up
  4. if you delete a member, it deletes the previous member and not the member i tried to delete, as well as having wonky error messages.

think you can fix it within PR 95, or should it be addressed in a follow up PR?

I created https://github.com/near/ui.multisafe/issues/97