Closed marcinbodnar closed 2 years ago
Thanks @judith-Near , I will handle it in a separate PR.
talking about regarding validation, the issue is also on the "edit members".
steps to reproduce:
- click add member
- write a new member id
- things are fine until you click add member a second time -> then the error message shows up
- if you delete a member, it deletes the previous member and not the member i tried to delete, as well as having wonky error messages.
think you can fix it within PR 95, or should it be addressed in a follow up PR?
Changes: 1. Added functionality to change Safe members. At first, I was planning to add changing members functionality to the
Members
page:add members
buttonremove
button next to every member. But the thing is that every action like that needs confirmation from members, so if the user would like to remove 2 members and add 1 member, he would have to create 3 requests. So it will not be a good UX. The more complicated to implement but at the same time better UX solution is to remove and add members on the same page and create one request instead of a few.2. Added functionality to change the number of confirmations. This is implemented as a separate form because it's not possible to change the members and number of confirmations in one request.
3. Added
Settings
section to the main menu. So far the options were scattered in the UI, so I decided to create 3 new forms:4. Reorganized the main menu.
Dashboard
andHistory
names didn't say much, so I change them to theRequests
section and two sub-items:Pending
andCompleted
.