search

agileware-jp / redmine_issue_templates

Redmine Issue Template. Pull requests, reporting issues, stars and sponsoring are always welcome!
https://www.redmine.org/plugins/redmine_issue_templates
GNU General Public License v2.0
65 stars 28 forks source link

Description is required but not working #18

Closed yui-har closed 1 year ago

yui-har commented 2 years ago

Summary

A description is required, but you can create a template without inputting a description.

issue_templates note_template

Environment

yui-har commented 1 year ago

https://github.com/agileware-jp/redmine_issue_templates/commit/d7a5f93dbd2cb139630ae385b8d32ccff392fbd3#diff-8db2731eaed983a50f821e80de6e76c4f64c78e97912f2bdabd10010d9893a44 Committed on Jul 19, 2012. Changed validates_presence_of to validates XXXXXXXXX, :presence => true, but validates :description, :presence not added. (is it forget?)

ScreenShot 2023-01-26 13 35 43

Perhaps other template models such as NoteTemplate and GlobalIssueTemplate are created by referring to (maybe copying and pasting?) this IssueTemplate. Therefore, each model's attribute corresponding to IssueTemplate#description not exist validates XXXXXXXXXXX, :presence => true.

yui-har commented 1 year ago

@zh Thank you for merging PR (#58 and #59). If there are no problems, please close this issue.

zh commented 1 year ago

PR merged master and 0.3-stable branches.