Use ApplicationRecord instead of ActiveRecord::Base from trunk r22619 - Githubissues

agileware-jp / redmine_issue_templates

Redmine Issue Template. Pull requests, reporting issues, stars and sponsoring are always welcome!

https://www.redmine.org/plugins/redmine_issue_templates

GNU General Public License v2.0

71 stars 33 forks source link

Use ApplicationRecord instead of ActiveRecord::Base from trunk r22619 #96

Closed maeda-m closed 6 months ago

maeda-m commented 7 months ago

Motivation / Background

Fixes #95.

Detail

Before Redmine trunk r22619, there was no ApplicationRecord class, so we dynamically determine and evaluate the class expression.

Additional information

We manually confirmed that template creation and usage are possible in the following environment combinations:

Ruby v2.7 x Redmine v4.2.11
Ruby v3.2 x Redmine v5.1.2
Ruby v3.2 x Redmine trunk (r22776)

nusohiro commented 6 months ago

commit# 403ccf3

This commit addresses an issue encountered when running Redmine v4.2 with an older version of selenium-webdriver. The older version of selenium-webdriver causes a NameError: uninitialized constant Selenium::WebDriver::Chrome::Options error.

To resolve this issue, we have added a step in the CircleCI configuration to update the selenium-webdriver gem to version 3.4.0 or later in the Gemfile.

nusohiro commented 6 months ago

@maeda-m

Thank you for your Pull Request and for contributing. Your effort is greatly appreciated!