agileware-jp / redmine_work_days

Redmine Work Days Plugin
18 stars 8 forks source link

Remove obsolete link name (reported by takaxp) #15

Closed zh closed 7 years ago

zh commented 7 years ago

Current PR is a fix for Issue #14 .

Redmine-3.4.x silently removed _link_to_contentupdate method from all sources. In fact even before that, the method was just a wrapper around the _linkto method (in all Redmine versions, back to 3.1.1):

# redmine : app/helpers/application_helper.rb
def link_to_content_update(text, url_params = {}, html_options = {})
  link_to(text, url_params, html_options)
end

So I think the proposed by takaxp changes are legit and safe to be done. Tested the result with redmine -3.3.2 and redmine-3.4.0 - working without problems.

urimaro commented 7 years ago

Ruby >= 2.0 の対応は別途行うのでmergeしますー Thanks @zh & @springkuma.