search

agilgur5 / physijs-webpack

PhysiJS port for bundlers with out-of-the-box support for Webpack and Browserify
Other
9 stars 3 forks source link

Fixed collision event and added "loader" suffix to the worker. #1

Closed kegi closed 6 years ago

kegi commented 6 years ago

1) with newer version of webpack, loader suffix is now mandatory. "worker!..." => "worker-loader!..."

2) collision event were not fired anymore with the ammo version specified on that library. This fix is not breaking BC with older versions of ammo.

agilgur5 commented 6 years ago

@kegi thanks for the contributions. I never got a notification for this since I wasn't watching this repo because it was never actually working -- see the last line of https://github.com/agilgur5/physijs-webpack/commit/a4c6bf301a3bc61316c8c36afafd81d54b8f3d2b and also https://twitter.com/_drewpowers/status/907719141213200385 since apparently there are two NPM packages made by someone else that point to this repo despite it never being in a working state... :/

I randomly decided to take the time to actually get this to a working state this weekend and made a bunch of updates, see master. There's now two auto-configured versions for webpack and browserify

I reverted the commit that added the ammo.js NPM package as it's not associated with ammo's creator either and it's unclear what revision of ammo that package is using. Now it's using the same ammo.js from physijs-browserify which is the same as physijs. I've made some tiny modifications to it get it to require with Webpack without problems as well. As a result, I'm not sure that your commit around collision detection makes sense anymore and it wasn't clear why it wasn't breaking either (you seem to have an incomplete sentence)

I added the -loader suffix to worker in the process of updating everything as well.